fix(isISO8601): reject whitespace other than space as date-time separator - #2864
Open
abhijeet117 wants to merge 1 commit into
Open
fix(isISO8601): reject whitespace other than space as date-time separator#2864abhijeet117 wants to merge 1 commit into
abhijeet117 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2864 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 114 114
Lines 2599 2599
Branches 658 658
=========================================
Hits 2599 2599 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default
isISO8601pattern separated the date and time parts with[T\s], so tab, newline, form feed, and vertical tab were all accepted as separators. Neither ISO 8601 nor RFC 3339 permits these; RFC 3339 only adds the plain space by convention. This narrows the class to[T ], keeping the space while rejecting the rest.strictSeparator: truebehavior is unchanged.Testing
Reproduced before the fix:
isISO8601('2009-05-19\t14:39:22')and the newline, form feed, and vertical tab variants all returned true. Added a focused regression case intest/validators.test.jsthat fails on the old pattern and passes after the change.Checklist